Support node10 #423
Open
Support node10 #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-10 support to come later Forwarded: noble#422 Origin: CrossStream@6e0d5d6 Change-Id: Ie8c3b328fd8736a80a3b91fb23702cc4152943b4 Signed-off-by: Philippe Coval <[email protected]>
Origin: noble#423 Relate-to: abandonware/noble#2 Cc: @petersaints Change-Id: I72d4f9c553a2cd1387d82884d330a4aa35c28703 Signed-off-by: Philippe Coval <[email protected]>
rzr
force-pushed
the
sandbox/rzr/abandonware/review/master
branch
from
49f62f9 to
e0a8953
Compare
|
@rzr |
|
same problem |
|
There's a fork that uses the @abandonware/node-bluetooth-hci-socket instead
of the oficial node-bluetooth-hci-socket package:
https://github.com/abandonware/bleno
This fork works on Node 10 LTS. Maybe you'll find it useful as I did.
However, I'd still love to see the work that has been done to get noble,
bleno and node-bluetooth-hci-socket working under Node 10 LTS merged into
the original repository and released on npm.
…On Fri, Mar 22, 2019 at 11:01 AM Michael Schwarz ***@***.***> wrote:
An update to Node10 LTS would be great. This would allow me to use Bleno
with Node crypto library to establish a secure connection. Crypto has
unfortunately very limited possibilities in Node8.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#423 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAJocgpYqVdGZETgCgS4EDpRm6_0t_-yks5vZLgdgaJpZM4ZcgSV>
.
|
|
Please review, on npm too, then track: |
Merge this small changes with the "/sandbox/rzr/abandonware/review/master" in order to release it as @abadonware/bleno on npm
|
This change is released in: |
|
Please confirm this issue is resolved with @abandonware version Relate-to: abandonware#17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc: @petersaints